Minor fixes for mkdocs serve rebuild and others
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added check for the `no current event loop` exception thrown by asyncio on rebuild - Delayed file cleanup for the pdf aggregator to avoid deleting files before the PDF is saved. - Guarantee the creation of the `pdf.pages[].formats` property
|
I got the same error message as #48 I eagerly await this PR to be part of the next release. |
AdrianDC
reviewed
Dec 14, 2024
| except FileNotFoundError: | ||
| pass | ||
|
|
||
|
|
There was a problem hiding this comment.
👍 I had that one once, on a 10-20 pages documentation.
Detail, remove the two extra empty lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no current event loopexception thrown by asyncio on rebuild (RuntimeError whenmkdocs serverebuilds #47)pdf.pages[].formatsproperty ('Page' object has no attribute 'formats'when usingmkdocs-print-site-plugin#48)