Delete the timer based measurement since we've switched over to #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
commented
Dec 20, 2024
resources/params.mjs
Outdated
| @@ -122,8 +122,8 @@ class Params { | |||
| if (!searchParams.has("measurementMethod")) | |||
| return defaultParams.measurementMethod; | |||
| const measurementMethod = searchParams.get("measurementMethod"); | |||
| if (measurementMethod !== "timer" && measurementMethod !== "raf") | |||
| throw new Error(`Invalid measurement method: '${measurementMethod}', must be either 'raf' or 'timer'.`); | |||
| if (measurementMethod !== "raf") | |||
There was a problem hiding this comment.
I kept this here since we may want to support "async" as an option now.
rniwa
force-pushed
the
delete-timer-test-invoker
branch
from
5661819 to
1393174
Compare
flashdesignory
approved these changes
Dec 20, 2024
smaug----
approved these changes
Dec 20, 2024
julienw
approved these changes
Dec 20, 2024
requestAnimationFrame based measurement for 3.0 and found no issues.
rniwa
force-pushed
the
delete-timer-test-invoker
branch
from
1393174 to
6c58ff6
Compare
|
I don't know what keeping the UI mean here because it's a checkbox with "rAF timing" label. Are you thinking of replacing that with "Async timing" or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestAnimationFrame based measurement for 3.0 and found no issues.