Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gallery): add rtl support #8085

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компонента Gallery не поддерживает отображение в rtl режиме. Нужно добавить поддержку этого режима

Изменения

  • Доработал логику компонента. Добавил поддержку rtl
  • Добавил тесты для функционала с rtl
  • Добавил скриншоты с rtl

Release notes

Улучшения

  • Gallery: Добавлена поддержка rtl

Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size
JS 390.22 KB (+0.21% 🔺)
JS (gzip) 118.56 KB (+0.32% 🔺)
JS (brotli) 97.64 KB (+0.38% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.76 KB (+0.05% 🔺)
CSS (gzip) 42.47 KB (+0.05% 🔺)
CSS (brotli) 33.83 KB (+0.03% 🔺)

Copy link

codesandbox-ci bot commented Dec 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit d825f50

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 95.37037% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.55%. Comparing base (ba6b9c4) to head (3267f55).

Files with missing lines Patch % Lines
...ckages/vkui/src/components/CarouselBase/helpers.ts 92.72% 4 Missing ⚠️
packages/vkui/src/helpers/getValueByCheckedKey.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8085      +/-   ##
==========================================
- Coverage   95.55%   95.55%   -0.01%     
==========================================
  Files         398      399       +1     
  Lines       11351    11405      +54     
  Branches     3741     3769      +28     
==========================================
+ Hits        10847    10898      +51     
- Misses        504      507       +3     
Flag Coverage Δ
unittests 95.55% <95.37%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon modified the milestones: v7.1.0, v7.2.0 Dec 19, 2024
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants