-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gateway edition to healthcheck response #6679
base: master
Are you sure you want to change the base?
Conversation
A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄 Your branch: exp/add-edition-info-to-healthcheck Your PR title: Add gateway edition to healthcheck response Your PR description: DescriptionRelated IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
API Changes --- prev.txt 2024-10-29 07:41:57.696286096 +0000
+++ current.txt 2024-10-29 07:41:51.312279831 +0000
@@ -1862,6 +1862,7 @@
Output string `json:"output,omitempty"`
Description string `json:"description,omitempty"`
Details map[string]HealthCheckItem `json:"details,omitempty"`
+ Edition string `json:"edition,omitempty"`
}
type HealthCheckStatus string |
Quality Gate failedFailed conditions |
User description
Description
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
PR Type
enhancement
Description
Edition
field to theHealthCheckResponse
struct to include edition information in the health check response.GetEdition
function in separate files for Community and Enterprise editions to return the respective edition strings.liveCheckHandler
to populate theEdition
field using theGetEdition
function.PRDescriptionHeader.CHANGES_WALKTHROUGH
health_check.go
Add Edition field to HealthCheckResponse struct
apidef/health_check.go
Edition
field toHealthCheckResponse
struct.health_check.go
Include Edition information in health check response
gateway/health_check.go
edition
package.Edition
field inHealthCheckResponse
usingedition.GetEdition()
.edition_ce.go
Define GetEdition function for Community edition
internal/edition/edition_ce.go
GetEdition
function returning "Community".edition_ee.go
Define GetEdition function for Enterprise edition
internal/edition/edition_ee.go
GetEdition
function returning "Enterprise".