Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PMD to 7.8.0 and spotbugs to 4.8.6 #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jimver
Copy link

@Jimver Jimver commented Dec 30, 2024

  • Bump the pmd dependency from 6.0.0 to the latest version 7.8.0.
  • This is needed in particular for Java 21 support. See https://pmd.github.io/pmd/pmd_languages_java.html
  • Changed the PmdProcessor to be compatible with the new PMD 7.8.0 version.
  • For PMD we now just use the PmdAnalysis class to perform the PMD checks based on our PMDConfiguration, giving back the Report.
  • Therefore, we don't need to do our own manual CollectorRenderer anymore, so that is now removed.
  • Note that the rulesets have changed to be category based in the test properties, this will also need to be updated in the properties of end users.
  • Bump the spotbugs dependency from 4.2.0 to the latest version 4.8.6.
  • This is needed for Java 21 support, see spotbugs releasenotes: https://github.com/spotbugs/spotbugs/releases/tag/4.8.0
  • Need to exclude logback from spotbugs since it's a newer version compiled with class version 55 (we are still on class version 52 with JDK 1.8).
  • The PMD and spotbugs bumps are done in unison as they both use the saxon dependency.

@Jimver Jimver marked this pull request as ready for review December 30, 2024 14:03
- Bump the pmd dependency from 6.0.0 to the latest version 7.8.0.
- This is needed in particular for Java 21 support.
- Changed the PmdProcessor to be compatible with the new PMD 7.8.0
  version.
- For PMD we now just use the PmdAnalysis class to perform the PMD
  checks based on our PMDConfiguration, giving back the Report.
- Therefore, we don't need to do our own manual CollectorRenderer
  anymore, so that is now removed.
- Note that the rulesets have changed to be category based in the test
  properties, this will also need to be updated in the properties of end
  users.
- Bump the spotbugs dependency from 4.2.0 to the latest version 4.8.6.
- This is needed for Java 21 support, see spotbugs releasenotes:
  https://github.com/spotbugs/spotbugs/releases/tag/4.8.0
- Need to exclude logback from spotbugs since it's a newer version
  compiled with class version 55 (we are still on class version 52 with
  JDK 1.8).
- The PMD and spotbugs bumps are done in unison as they both use the
  saxon dependency.
@Jimver Jimver changed the title Bump PMD to 7.8.0 Bump PMD to 7.8.0 and spotbugs to 4.8.6 Dec 30, 2024
@Jimver
Copy link
Author

Jimver commented Dec 30, 2024

Fixes #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant