Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Router: Correct terminology and fix punctuation #29242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Maddily
Copy link
Contributor

@Maddily Maddily commented Dec 28, 2024

Because

The lesson incorrectly uses "tag" to describe the index property, and a missing period affects readability. This PR fixes these issues.

This PR

-Corrects the use of "tag" to "property" when describing the index configuration in React Router.
-Adds a missing period to improve sentence structure.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The lesson calls `index` a "tag", but the term "tag" isn't used in React Router's docs to refer to the `index` property. Instead, `index` should be referred to as a property or key.
@github-actions github-actions bot added the Content: React Involves the React course label Dec 28, 2024
@rlmoser99 rlmoser99 requested review from a team and wise-king-sullyman and removed request for a team December 31, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant