Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update combination_sum.py #12431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update combination_sum.py #12431

wants to merge 2 commits into from

Conversation

yuvashrikarunakaran
Copy link

Here is the updated and clearer version of the code with improved readability, type annotations, and error handling for invalid inputs.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

yuvashrikarunakaran and others added 2 commits December 12, 2024 08:42
@yuvashrikarunakaran
Update combination_sum.py
c4376ca 
Here is the updated and clearer version of the code with improved readability, type annotations, and error handling for invalid inputs.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
10f3e42 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Dec 12, 2024
imSanko
imSanko suggested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try Running pre commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvashrikarunakaran @imSanko