Improvements to Vampire Number #6110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused code - Just print formatted lines instead of accumulating them in a StringBuilder - Rename the method to reflect what it does - Make pseudo vampire number choice an argument
- Fix a bug in check for pseudo vampire number - Make method that split into digits accept vararg and slightly simplify it
…er to the beginning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6110 +/- ##
============================================
+ Coverage 73.64% 73.74% +0.10%
- Complexity 5112 5119 +7
============================================
Files 658 658
Lines 17649 17641 -8
Branches 3396 3394 -2
============================================
+ Hits 12997 13010 +13
+ Misses 4147 4127 -20
+ Partials 505 504 -1 ☔ View full report in Codecov by Sentry. |
Shisoik
requested review from
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
|
IMHO, limiting tests to just 3 static imports and forbidding to static import org.junit.jupiter.api.Assertions.* is too strict and actually hurts readability. Not gonna argue, juest a thought. |
siriak
reviewed
Dec 24, 2024
| // methode to Split the numbers to Digits | ||
| static String splitIntoDigits(int num, int num2) { | ||
| StringBuilder res = new StringBuilder(); | ||
| static void printVampireNumbers(int startValue, int stopValue, boolean ignorePseudoVampireNumbers) { |
There was a problem hiding this comment.
Please remove main and printVampireNumbers, we don't usually add visualization, only algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to maths/VampireNumber code:
clang-format -i --style=file path/to/your/file.java