coverity fix, missing break

[andyfox-rushc]

No description provided.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[andyfox-rushc]

In response to Ethan's request in another thread related to this pull request I have removed a number of pointer checks (which I had put in to calm coverity).

I think there is a general pattern which was causing the issue: when creating a buffer we rationally expect it to have valid iterms and to simply always be able to get the iterm safely. So I have added this api call:
odb::dbITerm* db_network::staToDb(buffer_ip_pin);

This one will check the type of the pin and return the iterm, & if not an iterm error out. It turns out that we are creating buffers all over the place and in all those cases want to get the iterm without being concerned with the possible bterm, modbterm, moditerm alternatives so this seems like a fair way of getting the iterm from the buffer pin.

The api call dbNetwork::flatPin -- will also attempt to return the iterm but will not error out, and instead return null (this is useful in its own right).

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[maliberty]

Where is "another thread"?