Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ktor version to stable v3 #83

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Upgrade Ktor version to stable v3 #83

wants to merge 6 commits into from

Conversation

Taewan-P
Copy link
Owner

@Taewan-P Taewan-P added the enhancement New feature or request label Oct 26, 2024
@Taewan-P Taewan-P self-assigned this Oct 26, 2024
@Taewan-P Taewan-P marked this pull request as ready for review November 23, 2024 06:50
@Taewan-P Taewan-P requested a review from Copilot November 23, 2024 10:54
Copilot
Copilot AI reviewed Nov 23, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/data/network/AnthropicAPIImpl.kt: Language not supported
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/data/network/NetworkClient.kt: Language not supported
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

Build complete! Here's the debug APK: https://github.com/Taewan-P/gpt_mobile/actions/runs/11986670558/artifacts/2227870712

@Taewan-P Taewan-P marked this pull request as draft November 25, 2024 12:34
@Taewan-P
Copy link
Owner Author

This PR cannot be merged until google-gemini/generative-ai-android#222 is solved due to dependency issues.

Or implementing Gemini API with Ktor V3 and removing the generative ai SDK can also solve the build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

Assignees

@Taewan-P Taewan-P

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Taewan-P