Using latest protobuf version, fixing protoc-gen-js install... #30
Conversation
…ocker helper script
|
Kudos, SonarCloud Quality Gate passed!
|
| ARG PROTOC_GEN_GO_VERSION=v1.28.1 | ||
| ARG PROTOC_GEN_GO_GRPC_VERSION=v1.1.0 | ||
| ARG GRPC_VERSION=v1.50.0 |
There was a problem hiding this comment.
Does this impact the Python build? There's specific reasons why we selected this gRPC version.
There was a problem hiding this comment.
I'm inclined to say no since the generated python output hasn't changed, but I could verify this with local testing.
There was a problem hiding this comment.
If no, then ok. Do verify quickly, though.
There was a problem hiding this comment.
The version of protoc built here is not used, see here:
#27
| WORKDIR /build | ||
| RUN git clone --recurse-submodules -b ${GRPC_VERSION} --depth 1 --shallow-submodules https://github.com/grpc/grpc | ||
| WORKDIR /build/grpc | ||
| RUN mkdir -p cmake/build; cd cmake/build; cmake -DgRPC_INSTALL=ON -DgRPC_BUILD_TESTS=OFF -DCMAKE_INSTALL_PREFIX=/usr/local ../.. && make -j 8 && make install | ||
|
|
||
| # Install protoc-gen-js | ||
| WORKDIR /build/protoc-gen-js | ||
| RUN wget -O protobuf-javascript.zip https://github.com/protocolbuffers/protobuf-javascript/releases/download/v${PROTOBUF_JAVASCRIPT_VERSION}/protobuf-javascript-${PROTOBUF_JAVASCRIPT_VERSION}-linux-x86_64.zip && \ |
There was a problem hiding this comment.
Wrap these super-long lines please.
There was a problem hiding this comment.
It would seem to me that doing a git checkout to a release branch is a lot less brittle than this.
There was a problem hiding this comment.
It would seem to me that doing a git checkout to a release branch is a lot less brittle than this.
To be clear, are you suggesting that we do a git checkout of the release branch and build the binary in docker instead of using the pre-built binary?
There was a problem hiding this comment.
Good question. Maybe? It would allow the protobufs to be built on non-x86-64 containers, but I'm not sure if this is relevant.
... and adding docker helper script for building outputs locally