-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding setting option for renaming new files on creation. #1494
base: master
Are you sure you want to change the base?
Conversation
This will allow users to disable the auto rename on file creation. It's annoying if you design your templates to already do the renaming. This will allow users to disable it.
Hey, just adding this quick setting to toggle on the auto file rename when creating new files. It was slightly annoying bc I already do this in my templates and it's not needed twice. I suspect others might like this too, if not.. no worries. |
I think this is a great idea, thank you for putting this together! I have a few thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment for requested changes.
hey Zachatoo, sure I can make those changes. Sorry for not getting back to you sooner, Github didn't tell me I had any messages until I went to look! |
I made the changes to update the setting name and I defaulted it to off, but I had a question about your first point:
I'm not sure what you mean by this. All my change does is bypass the active_leaf.setEphemeralState() call after the file is created. my use case is that I manually renamed the filename from inside the templater script. Either way, tp.file.title wouldn't be correct since the new file name is already created and the rename happened after all templater scripts were finished. |
This will allow users to disable the auto rename on file creation. It's annoying if you design your templates to already do the renaming. This will allow users to disable it.