Meta: Add User-Agent string on request for download_file #25608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
Dec 31, 2024
Meta/download_file.py
Outdated
| @@ -74,7 +74,7 @@ def main(): | |||
|
|
|||
| os.makedirs(output_file.parent, exist_ok=True) | |||
|
|
|||
| request = urllib.request.Request(args.url, headers={"Accept-Encoding": "gzip"}) | |||
| request = urllib.request.Request(args.url, headers={"Accept-Encoding": "gzip", "User-Agent": "Mozilla/5.0"}) | |||
There was a problem hiding this comment.
Does it have to be Moz/5.0, or does (e.g.) "serenityos Meta/download_file.py" work as well?
Thanks for the PR!
There was a problem hiding this comment.
I tested it and apparently it will work with anything, even an empty string, it just needs that the User-Agent be present in the request.
EduHCS
force-pushed
the
uefi-pnp-download-error
branch
from
28fe3d7 to
a6a7a13
Compare
nico
force-pushed
the
uefi-pnp-download-error
branch
from
a6a7a13 to
447aa54
Compare
|
Thanks! |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading pnp_ids.csv from https://uefi.org/uefi-pnp-export it needs to have a User-Agent string set, or it will return an 403: Forbidden error.