-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger spec modification #792
Open
spiegela
wants to merge
11
commits into
RackHD:master
Choose a base branch
from
spiegela:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/RackHD/on-http: Update LICENSE Add in retries around callback routine to avoid timeouts during install on bare metal nodes. RAC-6012 - removed the network option to address issues being seein in baremetal nodes. The network port is not always coming up in time to allow selection of which interface to start the kickstart on. DCIMCooling and DCIMPower Validation
* 'master' of https://github.com/RackHD/on-http: Remove the SB routes from on-http & fix DELETE /Template. jump version for new release 2.25.0 Replace the profiles and templates api implementations with grpc call into on-taskgraph # Conflicts: # static/monorail-2.0.yaml
The Copyright Check has failed!
|
Hi @spiegela, could you resolve the conflict? |
The Copyright Check has failed!
|
1 similar comment
The Copyright Check has failed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using the Swagger spec to update the GoRackHD project to 2.0, I'm suggesting some changes to the spec that generate a better client. Let me know if there are any questions on how these changes effect the generated client.
I'm happy to squash the commits, if you prefer when we're ready to merge, but wanted to leave them separated for review.
Thanks!