Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: rename native64 -> native #21100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OlegHahm
Copy link
Member

Contribution description

This patch renames the current native board into native32 and replaces it with the current native64 board.

The changeset is mostly renaming directories and replacing native64 with native32 within application Makefiles (unless native64) was not supported.

It's only superficially tested so far. Let's see what the CI comes up with.

Testing procedure

Use your favorite RIOT application on native.

@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools Area: boards Area: Board ports Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration labels Dec 21, 2024
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 21, 2024
@riot-ci
Copy link

riot-ci commented Dec 21, 2024

Murdock results

✔️ PASSED

f079269 test: pkg: special cases for native32 only

Success Failures Total Runtime
10249 0 10249 13m:26s

Artifacts

@OlegHahm OlegHahm force-pushed the pr/native64_as_default branch from 014321f to e4a8748 Compare December 21, 2024 00:50
@github-actions github-actions bot added the Area: sys Area: System label Dec 21, 2024
@miri64
Copy link
Member

miri64 commented Dec 21, 2024

Should we, while maybe more complicated, make the rename to native32 first, make a link to it as native (see e.g. feather-m0-lora for how to link a board variant) and then walk through our normal deprecation cycle for the relinking to native64? Or can we just assume that people want native64 ASAP and that native64 is stable enough by now to not cause any regressions?

@miri64
Copy link
Member

miri64 commented Dec 21, 2024

(maybe we should even integrate native64 into the release tests first)

@OlegHahm OlegHahm force-pushed the pr/native64_as_default branch 3 times, most recently from cf1eead to 7634654 Compare December 21, 2024 09:49
@OlegHahm
Copy link
Member Author

I think there is indeed no reason to rush it. Integrating it into the release tests, might be a good idea. But I don't get your proposal for the deprecation cycle. (Do we want to deprecated native 32 bit at all?)

@miri64
Copy link
Member

miri64 commented Dec 21, 2024

But I don't get your proposal for the deprecation cycle. (Do we want to deprecated native 32 bit at all?)

No, just the fact that native is native32, i.e., have native point to native32 and make a deprecation note, that it will point to native64 2 release cycles later.

@OlegHahm
Copy link
Member Author

Ah, understood. Not sure though whether this is necessary. After all native is most likely not used in production but rather for testing and debugging. It should work reliable, so extending the transition time is a good thing but we should make sure that more people are using the 64 bit variant during this transition time to check for its reliability.

@OlegHahm OlegHahm force-pushed the pr/native64_as_default branch from 7634654 to a37eeab Compare December 21, 2024 10:51
@OlegHahm OlegHahm force-pushed the pr/native64_as_default branch 2 times, most recently from 1c5964c to 2b47778 Compare December 21, 2024 14:02
This patch renames the current native board into native32 and replaces
it with the current native64 board.

The changeset is mostly renaming directories and replacing native64 with
native32 within application Makefiles (unless native64) was not
supported.
@OlegHahm OlegHahm force-pushed the pr/native64_as_default branch from 2b47778 to f079269 Compare December 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: doc Area: Documentation Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants