Refactor Variable CRUD methods in client #16564
Merged
+171
−110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16472, this PR continues the optimization pattern established for Artifacts, though with a smaller impact since Variables is one of our lighter primitives. The memory footprint reduction is negligible in this case, but the PR:
While the memory impact is minimal for Variables specifically, applying this pattern consistently across all primitives will help us reach our optimization targets in #16472. The refactoring maintains full feature parity while improving the module's organization and type safety.
fun fact: our previous async client didn't have a create method, while our sync one didn't have a read_variables method