Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA Support in CLI #16558

Conversation

dylanbhughes
Copy link
Contributor

@dylanbhughes dylanbhughes commented Dec 31, 2024

This PR adds SLA parsing & deployment functionality to the deploy CLI method.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #16558 will not alter performance

Comparing dylan/cloud-874-ensure-that-prefectyaml-supports-sla-configuration (6943dd2) with main (1c801c7)

Summary

✅ 3 untouched benchmarks

@dylanbhughes dylanbhughes marked this pull request as ready for review January 2, 2025 18:28
Copy link
Contributor

@sam-phinizy sam-phinizy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dylanbhughes dylanbhughes merged commit 5389c71 into dylanbhughes/deployment-sla Jan 2, 2025
37 checks passed
@dylanbhughes dylanbhughes deleted the dylan/cloud-874-ensure-that-prefectyaml-supports-sla-configuration branch January 2, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants