Refactor Client's Block CRUD methods into Mixin #16512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
reviewed
Dec 26, 2024
src/prefect/utilities/generics.py
Outdated
Comment on lines
8
to
22
| ListValidator = SchemaValidator( | ||
| schema=core_schema.list_schema( | ||
| items_schema=core_schema.dict_schema( | ||
| keys_schema=core_schema.str_schema(), values_schema=core_schema.any_schema() | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| def validate_list(model: type[T], input: Any) -> list[T]: | ||
| return [model.model_validate(item) for item in ListValidator.validate_python(input)] | ||
|
|
||
|
|
||
| def ListAdapter(model: type[T]) -> Callable[[Any], list[T]]: | ||
| return lambda input: validate_list(model, input) |
There was a problem hiding this comment.
why not just have an adapter like TypeAdapter(list[T])?
There was a problem hiding this comment.
I had an early version of this that made a type adapter for every list, but the memory profile was bigger than I liked. tl;dr you basically have to pay the size of the ListSchemaValidator per object if you do it that way, which felt like a high tax.
There was a problem hiding this comment.
that makes sense. unrelated, can we use partial instead of lambda here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16472 this PR builds on (and follows the patterns of) #16496 to reduce the memory footprint of importing PrefectClient from 34MB to 29.9MB. This represents a 10% reduction in footprint from #16496 and 12% reduction from where we started.