regrepeat: Use new utf8_to_uv; not utf8_to_uvchr_buf #22827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a subtle bug fix when the input is malformed UTF-8. We say we don't support malformed, but this commit is a step towards better protecting against that eventuality. Prior to this commit, some patterns that use regrepeat() would exhibit different matching behavior of malformed input depending on if utf8 warnings were enabled or not. This is because utf8_to_uvchr_buf() returns NUL if utf8 warnings are on; and the REPLACEMENT CHARACTER if they are off. If the match criteria accepts one but not the other, the behavior would differ. Now, the repetition stops immediately without it being considered a match when a malformed input character is found
tonycoz
approved these changes
Dec 10, 2024
|
@tonycoz approved this, but I'm wondering if it would be better to treat this (and similar) issues as a run-time error, and croak should malformed UTF-8 be encountered. The commit causes the repeat to stop at the first such one, but maybe it's better to not continue at all. We pretty much assume that by the time strings get here, they have been validated. @demerphq what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtle bug fix when the input is malformed UTF-8. We say we don't support malformed, but this commit is a step towards better protecting against that eventuality.
Prior to this commit, some patterns that use regrepeat() would exhibit different matching behavior of malformed input depending on if utf8 warnings were enabled or not.
This is because utf8_to_uvchr_buf() returns NUL if utf8 warnings are on; and the REPLACEMENT CHARACTER if they are off. If the match criteria accepts one but not the other, the behavior would differ.
Now, the repetition stops immediately without it being considered a match when a malformed input character is found