-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add no_validate
Flag To @router.command
#6988
Open
deeleeramone
wants to merge
15
commits into
develop
Choose a base branch
from
feature/validate-command-kwarg
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeleeramone
added
enhancement
Enhancement
platform
OpenBB Platform
v4
PRs for v4
labels
Dec 14, 2024
…e to ExecutionContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
What?:
@router.command(..., no_validate=True)
, in the function's router will defeat output type checking and validation by enforcing "response_model=None" and removing the response annotation.openapi_extra["no_validate"]
CommandValidator
Impact:
@router.command
decorator explicitly hasno_validate=True
.PackageBuilder
andReferenceGenerator
asAny
Testing Done:
To use, add
no_validate=True
to any router command. False is an equivalent to None.This will raise a ValueError when set to False, but works when True.
CommandRunner will reject a non-OBBject if
no_validate=False
or is not defined. This is done by exposing the ApiRoute and checkingopenapi_extra
, where the @router.command kwarg is stored.reference.json
replaces theReturns
section with: