Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] fetchgit{,hub,lab}: passthru rev based on tag #370768

Merged
merged 3 commits into from
Jan 4, 2025
Merged

[Backport release-24.11] fetchgit{,hub,lab}: passthru rev based on tag #370768

merged 3 commits into from
Jan 4, 2025
+9 −7

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Jan 4, 2025 •
edited by Atemu
Loading

Bot-based backport to release-24.11, triggered by a label in #369506.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@nix-backports nix-backports bot mentioned this pull request Jan 4, 2025
Merged
13 tasks
@nix-owners nix-owners bot requested a review from philiptaron January 4, 2025 01:06
pbsds
pbsds approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changed behavior on evemu.src, snoop.src and kazumi.src in the repl.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 4, 2025
@pbsds pbsds requested a review from Atemu January 4, 2025 01:13
@Atemu
Copy link
Member

Atemu commented Jan 4, 2025

I was going to wait overnight for CI but it's so fast now.

@Atemu Atemu merged commit a4c40a8 into release-24.11 Jan 4, 2025
27 checks passed
@Atemu Atemu deleted the backport-369506-to-release-24.11 branch January 4, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds pbsds approved these changes

@philiptaron philiptaron Awaiting requested review from philiptaron

@Atemu Atemu Awaiting requested review from Atemu

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Atemu @pbsds