-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ardour: use librdf_raptor2 #369048
ardour: use librdf_raptor2 #369048
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but please rename the commit so that it follows the Commit Conventions.
Something like this should work: ardour: switch to librdf_raptor2
It seems like Ardour and Sonic Visualiser are the only remaining references to the old version. Looking at the upstream build scripts for the latter, the latest version works with Raptor 2. I take it Ardour 7 will continue to fail to compile? Can it be made to work with Raptor 2 as well, perhaps by backporting upstream commits from the Ardour 8 branch? Otherwise, perhaps 25.05 is the release to remove Ardour 7 and Raptor 1 in; cc @magnetophon due to the discussion in #336093. |
879df03
to
e203dd4
Compare
@SigmaSquadron, sorry, fixed. @emilazy, based on Fedora packages, ardour7 should also be able to compile with raptor2. Maybe a maintainer can say whether to update both packages in this PR or to open a separate one. |
Same PR (but a separate commit, |
Since both lrdf and librdf_rasqal propagate librdf_raptor2, this patch removes the direct dependency.
e203dd4
to
95cafc4
Compare
I tried building ardour_7 with the same fix, but it seems something else is broken in the build as well. |
Sorry to be absent from the discussion. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried building ardour_7 with the same fix, but it seems something else is broken in the build as well.
Apologies, I missed this comment and thought we were waiting on appending that to this PR. Going to merge so we can get this fixed, at least.
Recently, the raptor library stopped building in nixpkgs (#368134). This is likely due to an incompatible function declaration brought to light by the recent switch to GCC14.
This means that ardour fails to build as well. However, based on nightly CI builds, ardour is no longer using raptor 1.4.21, but raptor 2.0.14. Therefore, this PR updates ardour to use raptor 2.0.16 in nixpkgs, fixing the build.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.