Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

butterfly: 2.2.2 -> 2.2.3 #367867

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

butterfly: 2.2.2 -> 2.2.3 #367867

wants to merge 2 commits into from
+209 −233

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Dec 24, 2024

https://github.com/LinwoodDev/Butterfly/releases/tag/v2.2.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 24, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4998

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 24, 2024
@aucub aucub force-pushed the butterfly branch 2 times, most recently from 9cd7ea5 to 4007f5b Compare December 28, 2024 01:41
@CodeDoctorDE
Copy link

Hello,
I just wanted to say thank you for packaging my app.
If I could make something that helps maintaining this, feel free to contact me.
I would put this as install method on the website if its okay?

@aucub aucub added the backport release-24.11 Backport PR automatically label Jan 4, 2025
@aucub
Copy link
Contributor Author

aucub commented Jan 4, 2025

Hello, I just wanted to say thank you for packaging my app. If I could make something that helps maintaining this, feel free to contact me. I would put this as install method on the website if its okay?

Thank you for developing this application. You have the ability to accomplish what you set out to do.

@aucub
Copy link
Contributor Author

aucub commented Jan 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367867

x86_64-linux

✅ 3 packages built:
  • butterfly
  • butterfly.debug
  • butterfly.pubcache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aucub @nixos-discourse @CodeDoctorDE @SuperSandro2000