Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DrupalWiki collector #2770

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EugenMayer
Copy link

@EugenMayer EugenMayer commented Dec 8, 2024

Pull Request Type

  • ✨ feat

What is in this change?

As dicussed recently, we would like the contribute the new Drupal Wiki content collector.

Additional Information

Drupal Wiki content collector for Drupal Wiki on-prem and cloud instances.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@EugenMayer
Copy link
Author

Anybody that can hint me where possible updates in regard of

Relevant documentation has been updated

the documentation could be needed?

@andul
Copy link

andul commented Dec 9, 2024

Hi @timothycarambat , my colleague implemented the data connector mentioned in Issue 115. Can you please review and advise?

@EugenMayer EugenMayer force-pushed the feature/drupalwiki-collector branch from 182c70d to 2924651 Compare December 9, 2024 17:02
@EugenMayer
Copy link
Author

Regarding the docs all i could find mentioning the collectors is https://github.com/Mintplex-Labs/anythingllm-docs/blob/d3920da5259e83eb8896eea6266eb95332661f10/pages/beta-preview/active-features/live-document-sync.mdx#scope-of-documents - but those are examples. I can an Drupal Wiki is suggested anyway, let me know

@timothycarambat timothycarambat self-assigned this Dec 11, 2024
@timothycarambat timothycarambat added Integration Request Request for support of a new LLM, Embedder, or Vector database core-team-only labels Dec 11, 2024
@timothycarambat
Copy link
Member

Going to keep this PR open and change it into a data connector plugin when that is live - so that these same things can happen without direct PR review. It will work the same way as agent-skill plugins that are on hub.anythingllm.com

@EugenMayer
Copy link
Author

@timothycarambat thank you for the heads up. Are data-collectors already suppported on the hub and can be selected? If yes, are there any hints how i need to change the structure to match the marketplace-plugin arch? This way i can take up the work

@timothycarambat
Copy link
Member

They are not supported in the hub yet, but the object and framework exists for it already, we just need to figure out what a data-connector package will look like.

Conceptually it will basically be a bundle just like agent-skills and we will hot load them in the collector so they become available. This includes the UI elements in the data connector UI as well.

So there will be basically

  • config.js
  • handler.js (again)
  • any other supporting files

and it should all work the same way as agents since its super portable when all we are doing is unzipping content into a plugins/dataconnector folder in the storage.

I can share more once its set in stone what it looks like!

@EugenMayer
Copy link
Author

Thanks. So i assume right now, there is nothing i can do except waiting for either the specs for the new hub-based data-connectors to come out or for you to port it. In addition, the support to install those on the hub must be implemented.

Do you have any timeline on when the specs for such a bundle including the ability to install it via the hub could be ready?

Thank you for the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-team-only Integration Request Request for support of a new LLM, Embedder, or Vector database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants