Fallback to remote openpose editor when no local installation found. #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linjiX
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A1111 1.6.0 will automatically open a page in the browser, when the backend extensions were not fully initialized yet. This causes huchenlei/sd-webui-openpose-editor#53 where
checkEditorAvailableruns before the editor endpoint has been mounted yet.Since we recently deployed the editor on https://huchenlei.github.io/sd-webui-openpose-editor/, this PR makes a fallback onto the remote editor when local version is not available. This also means users can now access the editor even they do not have the editor extension installed.
The local version is still preferred as it is generally faster, and some users in mainland China can have bad connection to github.com domain.