Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external_code.py fix for issue 2132 2111 #2133

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

joergwa
Copy link
Contributor

@joergwa joergwa commented Sep 19, 2023

fix for #2132 #2111

@huchenlei
Copy link
Collaborator

huchenlei commented Sep 27, 2023

Can you explain how this PR fixes the issue listed?

@joergwa
Copy link
Contributor Author

joergwa commented Sep 28, 2023

change line 340 in sd-webui-controlnet/internal_controlnet/external_code.py

from: script_args = list(p.script_args)
to: script_args = p.script_args_value

p.script_args returns None, which it not iterable to create a list (raises the error).
p.script_args_value returns a list with None objects, which seems to be fine so far

print (type(p.script_args))
print (p.script_args)
print (type(p.script_args_value))
print (p.script_args_value)

<class 'NoneType'>
None
<class 'list'>
[None, None, None, None]

I am wondering, according to https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/modules/processing.py#L256 p.script_args is the getter of p.script_args_value and I expect both return the same value but they don't.

My guess is, that somewhere p.script_args has been overwritten.

@Florisdk
Copy link

It works!! Thank you a lot! I signed up specifically to tell you:-)

@huchenlei
Copy link
Collaborator

Tested locally and most functionalities work fine. LGTM on merge.

@huchenlei huchenlei merged commit e382d16 into Mikubill:main Oct 26, 2023
1 check passed
huchenlei added a commit that referenced this pull request Oct 28, 2023
huchenlei added a commit that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants