Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Enable EH Continuation Metadata #2159

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

JeromeMartinez
Copy link
Member

No description provided.

@cjee21
Copy link
Contributor

cjee21 commented Dec 2, 2024

Previously I did not enable CFG/CET for RegressionTest Release x64.

@cjee21
Copy link
Contributor

cjee21 commented Dec 2, 2024

Oh and there is also MediaInfoShellExt.vcxproj which has CFG/CET enabled for Release but not EHCONT.

@JeromeMartinez
Copy link
Member Author

Previously I did not enable CFG/CET for RegressionTest Release x64.

Not needed, removed.

Oh and there is also MediaInfoShellExt.vcxproj which has CFG/CET enabled for Release but not EHCONT.

Needed, added.

Thanks for double checking.

@cjee21
Copy link
Contributor

cjee21 commented Dec 2, 2024

@JeromeMartinez and I just discovered for ARM there is signret 😮 😆

@JeromeMartinez JeromeMartinez merged commit 6a54edf into MediaArea:master Dec 2, 2024
9 checks passed
@cjee21
Copy link
Contributor

cjee21 commented Dec 3, 2024

@JeromeMartinez and I just discovered for ARM there is signret 😮 😆

Looks like this option in Visual Studio is for enabling pointer authentication security mitigation on ARM.

@JeromeMartinez JeromeMartinez deleted the ehcont branch December 3, 2024 09:55
@JeromeMartinez
Copy link
Member Author

Looks like this option in Visual Studio is for enabling pointer authentication security mitigation on ARM.

I'll let you manage that :-p.
(after ARM PRs are merged)

@cjee21
Copy link
Contributor

cjee21 commented Dec 3, 2024

I'll let you manage that :-p. (after ARM PRs are merged)

Might need to add ARM64EC or ARM64X build if you want to have native ARM MediaInfo.dll for the GUI on Windows 11 ARM64.

@JeromeMartinez
Copy link
Member Author

Might need to add ARM64EC or ARM64X build if you want to have native ARM MediaInfo.dll for the GUI on Windows 11 ARM64.

After the first shot with DLL and CLI.

@cjee21
Copy link
Contributor

cjee21 commented Dec 3, 2024

CLI.

If you make the CLI fully ARM64, need to build an ARM64 graph plugin for it right?

@JeromeMartinez
Copy link
Member Author

If you make the CLI fully ARM64, need to build an ARM64 graph plugin for it right?

And FFmpeg plugin. But really not the priority, ARM64 is already low usage, ARM64 plugins even lower.

@cjee21
Copy link
Contributor

cjee21 commented Dec 3, 2024

And FFmpeg plugin. But really not the priority, ARM64 is already low usage, ARM64 plugins even lower.

Or can just make the CLI ARM64EC so that it has native performance but can load x64 plugins.

Microsoft and Qualcomm keeps pushing ARM64 so if they succeed, usage may increase significantly.

@JeromeMartinez
Copy link
Member Author

Or can just make the CLI ARM64EC so that it has native performance but can load x64 plugins.

Could work in this way? I thought it was ARM64EC = x64 --> ARM64EC, not ARM64EC --> x64.
Anyway, I think I prefer to build all native for the plugins, not the most difficult.
We'll see.
For the moment, really not the priority, CLI is already a bonus, the sponsorship being only on MediaInfo DLL without plugins.

@cjee21
Copy link
Contributor

cjee21 commented Dec 3, 2024

Could work in this way? I thought it was ARM64EC = x64 --> ARM64EC, not ARM64EC --> x64.

From what I read and understood, ARM64EC means can interface with x64 and ARM64EC any way we want but not with ARM64.

There is also ARM64X which is ARM64 and ARM64EC in the same binary with size savings. This single binary can interface with x64, ARM64 and ARM64EC binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants