Fix build on nightly #299
Merged
Fix build on nightly #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ecosystem has largely moved from the former to the latter.
tamird
force-pushed
the
fix-nightly
branch
4 times, most recently
from
6f32e5a to
5e84380
Compare
Manishearth
approved these changes
Dec 27, 2024
|
rustc-nightly-feature CI still fails |
|
Still in favor of moving off of lazy-static, so that's fine. Can we not use once_cell from the stdlib? |
|
Probably - I wasn't sure about MSRV. I'm working on bisecting the nightly linking failure. |
|
Filed rust-lang/rust#134825 for the rustc-nightly-feature failure. |
|
1.70 is totally fine for MSRV! |
|
I think we'd need 1.80.0: https://doc.rust-lang.org/stable/std/sync/struct.LazyLock.html. |
|
We can use OnceLock. We also currently do not guarantee an MSRV anyway, but I would like to avoid bumping too much if it's unnecessary, and OnceLock works here. |
|
#300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth