Implement damage reflection skill #479
Draft
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-n
requested changes
Sep 3, 2024
src/Persistence/Initialization/Skills/ReflectionEffectInitializer.cs
Outdated
Show resolved
Hide resolved
| var boostPerEnergy = this.Context.CreateNew<AttributeRelationship>(); | ||
| boostPerEnergy.InputAttribute = Stats.TotalEnergy.GetPersistent(this.GameConfiguration); | ||
| boostPerEnergy.InputOperator = InputOperator.ExponentiateByAttribute; | ||
| boostPerEnergy.InputOperand = 1 - (0.01f / 42f); |
There was a problem hiding this comment.
Considering that it's 1% for every 42 energy points, is there a reason why it has to be divided by 40?
Or maybe the formula I put forward is not correct. I found it on a forum that claimed it was the "official" formula.
There was a problem hiding this comment.
Oh okay, I found this one: https://guidescroll.com/2011/08/mu-online-summoner-guide/
There was a problem hiding this comment.
I found this in the published sources:
https://forum.ragezone.com/threads/development-season-12-full-src-gs.1193275/page-4#post-9193953
src/Persistence/Initialization/Skills/ReflectionEffectInitializer.cs
Outdated
Show resolved
Hide resolved
sven-n
reviewed
Sep 3, 2024
src/Persistence/Initialization/Skills/ReflectionEffectInitializer.cs
Outdated
Show resolved
Hide resolved
sven-n
requested changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Damage Reflection skill.
As I've read, I should implement a reflection according to the following formula:
30+(Total Energy/42)
I've implemented the basics, but I think I'm not understanding the powerup formula system well, since when I check the reflectiondamage (from the stat), it has values well below the minimum 0.3 expected.