Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swapped _R_co and _P to prevent type error. #20508

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TresYap
Copy link

@TresYap TresYap commented Dec 19, 2024

When loading a pytorch-lightning model from MLFlow, I get TypeError: Type parameter +_R_co without a default follows type parameter with a default. This happens whenever doing import pytorch_lightning as pl which is done by packages like MLFlow.

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20508.org.readthedocs.build/en/20508/

When loading a pytorch-lightning model from MLFlow, I get `TypeError: Type parameter +_R_co without a default follows type parameter with a default`.  This happens whenever doing `import pytorch_lightning as pl` which is done by packages like MLFlow.
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 19, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (9177ec0) to head (37e25f3).

❗ There is a different number of reports uploaded between BASE (9177ec0) and HEAD (37e25f3). Click for more details.

HEAD has 539 uploads less than BASE
Flag BASE (9177ec0) HEAD (37e25f3)
gpu 5 0
pytest 76 0
lightning_fabric 21 0
lightning 109 18
cpu 143 24
python3.9 36 6
python3.11 36 6
python3.10 18 3
python3.12.7 53 9
pytorch2.1 27 9
pytest-full 72 24
pytorch2.2.2 9 3
pytorch2.3 9 3
pytorch_lightning 18 6
pytorch2.4.1 9 3
pytorch2.5.1 18 6
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20508     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23380    23325     -55     
=========================================
- Hits        20481    18366   -2115     
- Misses       2899     4959   +2060     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants