Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No expiry on mocks #178

Closed
wants to merge 2 commits into from
Closed

No expiry on mocks #178

wants to merge 2 commits into from

Conversation

notjaywu
Copy link

@notjaywu notjaywu commented Jul 12, 2024

Close INS-4164

@notjaywu notjaywu requested a review from jackkav July 12, 2024 07:11
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jackkav jackkav closed this Jul 16, 2024
@jackkav
Copy link
Contributor

jackkav commented Jul 16, 2024

Closed in favour of setting a very long expiry, would be interested in passing 0 or no number translating to no expiry rather than removing the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants