Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IFCImporter): fix normals #3191

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

daker
Copy link
Collaborator

@daker daker commented Dec 15, 2024

Context

fix #3189

Results

Enregistrement.2024-12-15.165508.mp4

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker force-pushed the fix-ifc-merged-normals branch 3 times, most recently from dacb9b6 to fbe9b4f Compare December 15, 2024 21:26
@daker daker force-pushed the fix-ifc-merged-normals branch from fbe9b4f to af3e81a Compare December 17, 2024 14:31
@daker daker requested a review from finetjul December 18, 2024 14:38
@daker daker force-pushed the fix-ifc-merged-normals branch from af3e81a to ff1cf8c Compare December 18, 2024 16:23
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Jan 2, 2025
Merged via the queue into Kitware:master with commit b208ebb Jan 2, 2025
3 checks passed
@daker daker deleted the fix-ifc-merged-normals branch January 2, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong normals in IFC ?
3 participants