Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for QtMsgType, QMessageLogContext and qt_message_output #814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redstrate
Copy link
Contributor

This allows Rust and CXX-Qt applications to send messages to the Qt logger.

@redstrate redstrate self-assigned this Jan 17, 2024
crates/cxx-qt-lib/src/core/qtlogging.rs Outdated Show resolved Hide resolved
examples/cargo_without_cmake/src/main.rs Outdated Show resolved Hide resolved
@redstrate redstrate marked this pull request as draft January 17, 2024 19:10
@Montel
Copy link
Contributor

Montel commented Jan 18, 2024

Hi,
could you add info in CHANGELOG file please ?
Thanks

@redstrate redstrate marked this pull request as ready for review February 11, 2024 19:13
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first pass, unfortunately the lifetimes need sorting out.

crates/cxx-qt-lib/src/core/qtlogging.rs Show resolved Hide resolved
crates/cxx-qt-lib/src/core/qtlogging.rs Outdated Show resolved Hide resolved
@redstrate redstrate force-pushed the wip/josh/qtlogging branch 6 times, most recently from 40efe50 to 7dc5dbb Compare August 11, 2024 14:55
@redstrate redstrate force-pushed the wip/josh/qtlogging branch 2 times, most recently from f519be1 to 78b72af Compare August 18, 2024 22:50
@redstrate redstrate force-pushed the wip/josh/qtlogging branch 3 times, most recently from bff8d3a to 88eaa9e Compare December 26, 2024 18:06
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f5afefe) to head (9e0cd75).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11967     11967           
=========================================
  Hits         11967     11967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redstrate redstrate force-pushed the wip/josh/qtlogging branch 3 times, most recently from 248f78f to d204d89 Compare December 31, 2024 15:00
This allows Rust and CXX-Qt applications to send messages to the Qt
logger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants