Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JuliaSyntaxHighlighting UUID #56852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tecosaur
Copy link
Contributor

TLDR; I made a silly mistake a while back, and this seems like the least bad option.


Unfortunately during development of the backported version of this stdlib, to avoid potential sysimage issues the UUID was temporarilly changed and I forgot to change it back.

This mistake lead to the backport/compat verison of the package having a different UUID from the in-tree stdlib. Beyond this being an embarassing mistake, it's also a pain because it means that we now have incorrect/invalid manifests.

A small mercy is that 1.12 hasn't been released yet, so the discrepancy currently only affects people using development Julia versions. Changing the UUID here will require these people to regenerate their manifests, but this seems like the lesser of too evils.

Appologies for the hassle all.

Unfortunately during development of the backported version of this
stdlib, to avoid potential sysimage issues the UUID was temporarilly
changed and I forgot to change it back.

This mistake lead to the backport/compat verison of the package having a
different UUID from the in-tree stdlib. Beyond this being an embarassing
mistake, it's also a pain because it means that we now have
incorrect/invalid manifests.

A small mercy is that 1.12 hasn't been released yet, so the discrepancy
currently only affects people using development Julia versions. Changing
the UUID here will require these people to regenerate their manifests,
but this seems like the lesser of too evils.
uuid = "dc6e5ff7-fb65-4e79-a425-ec3bc9c03011"
uuid = "ac6e5ff7-fb65-4e79-a425-ec3bc9c03011"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused, it seems that the UUID of JuliaSyntaxHighlighting.jl is specified as dc6e5ff7-fb65-4e79-a425-ec3bc9c03011 from the first commit.
So the current UUID seems to be correct?

https://github.com/JuliaLang/JuliaSyntaxHighlighting.jl/blame/19bd57b89c648592155156049addf67e0638eab1/Project.toml#L2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, so the mistake at the heart of this is:

development of the backported version of this stdlib, to avoid potential sysimage issues the UUID was temporarilly changed and I forgot to change it back.

The changed UUID (ac6e...) is what was registered in General as the backport/compat version: https://github.com/JuliaRegistries/General/blob/master/J/JuliaSyntaxHighlighting/Package.toml#L2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think JuliaSyntaxHighlighting.jl also needs a pr to change the UUID and the two prs might want to be merged at the same time?

@inkydragon inkydragon added the stdlib Julia's standard library label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embarrassing-bugfix Whoops! stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants