-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canny Edge Filter Demo #177
Conversation
Demo for canny edge filter has been added with this #164 Needs review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I'll take a closer look at the content tomorrow. It has the same format issue to #178 for both English and Julia; I only pick one for each and leave the rest for you.
img_gray = zeros( Gray{Float64}, 200, 200) | ||
img_gray[ 50:150, 50:150] .= 1 | ||
mosaicview( img_gray; nrow=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
img_gray = zeros( Gray{Float64}, 200, 200) | |
img_gray[ 50:150, 50:150] .= 1 | |
mosaicview( img_gray; nrow=1) | |
img_gray = zeros(Gray{Float64}, 200, 200) | |
img_gray[50:150, 50:150] .= 1 | |
mosaicview(img_gray; nrow=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- mosaicview( img_gray; nrow=1)
+ img_gray #hide #md
File has been updated with suggestions and some suggestions from #178 also incorporated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the demo you're working on wrt to issue JuliaImages/ImageEdgeDetection.jl#21 and JuliaImages/ImageDraw.jl#50?
@@ -0,0 +1,91 @@ | |||
# --- | |||
# cover: assets/corner.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to generate the cover image in this script. Please see other available demo files for how it's done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the demo you're working on wrt to issue JuliaImages/ImageEdgeDetection.jl#21 and JuliaImages/ImageDraw.jl#50?
Actually,I'm creating small examples for ideas of demos for my proposal...circle detection/measurement/processing is related to JuliaImages/ImageEdgeDetection.jl#21 and JuliaImages/ImageDraw.jl#50
Co-authored-by: Ashwani Rathee <[email protected]>
algo_sigma1 = Canny( | ||
spatial_scale = 1, | ||
high = ImageEdgeDetection.Percentile(80), | ||
low = ImageEdgeDetection.Percentile(20), | ||
); | ||
algo_sigma3 = Canny( | ||
spatial_scale = 5, | ||
high = ImageEdgeDetection.Percentile(80), | ||
low = ImageEdgeDetection.Percentile(20), | ||
); | ||
|
||
# Let's now compute the results with the `detect_edges` function | ||
|
||
img_edges1 = detect_edges(img_noise, algo_sigma1); | ||
img_edges3 = detect_edges(img_noise, algo_sigma3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you may notice in #183, it can be more expressive if you explore it via map
or list comprehension.
Demo for canny edge filter has been added with this #164
Needs review