Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canny Edge Filter Demo #177

Closed
wants to merge 3 commits into from
Closed

Canny Edge Filter Demo #177

wants to merge 3 commits into from

Conversation

ashwanirathee
Copy link
Member

Demo for canny edge filter has been added with this #164

Needs review

Demo for canny edge filter has been added with this #164

Needs review
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I'll take a closer look at the content tomorrow. It has the same format issue to #178 for both English and Julia; I only pick one for each and leave the rest for you.

Comment on lines 36 to 38
img_gray = zeros( Gray{Float64}, 200, 200)
img_gray[ 50:150, 50:150] .= 1
mosaicview( img_gray; nrow=1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
img_gray = zeros( Gray{Float64}, 200, 200)
img_gray[ 50:150, 50:150] .= 1
mosaicview( img_gray; nrow=1)
img_gray = zeros(Gray{Float64}, 200, 200)
img_gray[50:150, 50:150] .= 1
mosaicview(img_gray; nrow=1)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/examples/contours/canny_edge_demo.jl Outdated Show resolved Hide resolved
docs/examples/contours/canny_edge_demo.jl Outdated Show resolved Hide resolved
File has been updated with suggestions and some suggestions from #178 also incorporated.
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the demo you're working on wrt to issue JuliaImages/ImageEdgeDetection.jl#21 and JuliaImages/ImageDraw.jl#50?

@@ -0,0 +1,91 @@
# ---
# cover: assets/corner.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to generate the cover image in this script. Please see other available demo files for how it's done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the demo you're working on wrt to issue JuliaImages/ImageEdgeDetection.jl#21 and JuliaImages/ImageDraw.jl#50?
Actually,I'm creating small examples for ideas of demos for my proposal...circle detection/measurement/processing is related to JuliaImages/ImageEdgeDetection.jl#21 and JuliaImages/ImageDraw.jl#50

johnnychen94 added a commit that referenced this pull request Mar 20, 2021
Comment on lines +73 to +87
algo_sigma1 = Canny(
spatial_scale = 1,
high = ImageEdgeDetection.Percentile(80),
low = ImageEdgeDetection.Percentile(20),
);
algo_sigma3 = Canny(
spatial_scale = 5,
high = ImageEdgeDetection.Percentile(80),
low = ImageEdgeDetection.Percentile(20),
);

# Let's now compute the results with the `detect_edges` function

img_edges1 = detect_edges(img_noise, algo_sigma1);
img_edges3 = detect_edges(img_noise, algo_sigma3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you may notice in #183, it can be more expressive if you explore it via map or list comprehension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants