Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "ColorVectorSpace" to "0.9" #937

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ColorVectorSpace package from 0.6, 0.7, 0.8 to 0.6, 0.7, 0.8, 0.9.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@johnnychen94 johnnychen94 force-pushed the compathelper/new_version/2021-01-23-01-28-35-679-3351927024 branch from 6e365c8 to 3c7176f Compare January 23, 2021 01:28
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #937 (3c7176f) into master (810480a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files           9        9           
  Lines        1023     1023           
=======================================
  Hits          882      882           
  Misses        141      141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810480a...3c7176f. Read the comment docs.

@timholy
Copy link
Member

timholy commented Jan 23, 2021

For the record, my intention is to make ColorVectorSpace a dependency of ImageCore 0.9, so I don't think we need to merge this and similar PRs.

@kimikage kimikage mentioned this pull request Mar 4, 2021
@johnnychen94
Copy link
Member

johnnychen94 commented Apr 15, 2021

I'm merging this one to smoothen our upgrade process

JuliaImages/ImageCore.jl#157 (comment)

To smoothly migrate to ColorVectorSpace(CVS) 0.9, I'll separate the task into three steps:

  • declare compatibility to CVS in downstream packages
  • load CVS in ImageCore (What this PR does)
  • remove direct dependency to CVS in downstream packages

Otherwise, it's a little bit hard to make the CI and Pkg happy.

@johnnychen94 johnnychen94 merged commit 9988b11 into master Apr 15, 2021
@johnnychen94 johnnychen94 deleted the compathelper/new_version/2021-01-23-01-28-35-679-3351927024 branch April 15, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants