Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds swirl function #135

Closed
wants to merge 1 commit into from
Closed

Adds swirl function #135

wants to merge 1 commit into from

Conversation

paniash
Copy link

@paniash paniash commented Jul 13, 2021

This PR adds a swirl as a standard function.

Relevent issues: #133

@paniash paniash marked this pull request as draft July 13, 2021 08:24
@johnnychen94
Copy link
Member

To make it a standard library function, we need to:

  • polish the API:
    • should we take the scikit-image version, or invent our own?
    • The example swirl function uses the center point as the swirl center x0, I think we can let users decide where the swirl center is.
  • add tests
  • add documentation

You can take a look at imrotate function as an example. For tests purposes, we can use ReferenceTests.

@johnnychen94
Copy link
Member

Is there any plan to finish this PR?

@paniash
Copy link
Author

paniash commented Oct 1, 2021

Hi! Sorry, life's gotten in the way. Please feel free to go ahead. :-)

@johnnychen94
Copy link
Member

Thanks. I'm closing this in favor of #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants