-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imresize
/imrotate
fixed point
#129
Open
ginkulv
wants to merge
7
commits into
JuliaImages:master
Choose a base branch
from
ginkulv:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
515f11b
add imresize with fixed_point
ginkulv 342c9fd
add struct FixedPoint
ginkulv 8c60c63
add examples of imresize with fixed point
ginkulv 1d3fee9
rename FixedPoint to CenterPoint
ginkulv 81ffd49
refactor imresize with FixedPoint
ginkulv cb837d7
add some tests and fix the description for CenterPoint
ginkulv dd9d5c7
add some tests
ginkulv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
""" | ||
CenterPoint(dims) -> cp | ||
|
||
Create a fixed point which can be used in `imresize` and `imrotate` | ||
functions in order to keep the value in this point the same, i.e., | ||
|
||
```julia | ||
img[cp] == imgr[cp] | ||
``` | ||
""" | ||
struct CenterPoint{N} | ||
p::CartesianIndex{N} | ||
end | ||
|
||
CenterPoint(dims::Dims{N}) where N = CenterPoint{N}(CartesianIndex(dims)) | ||
CenterPoint(dims::Int64...) = CenterPoint(Tuple(dims)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only makes sure the function gets called and outputs something. We also need to test if the output is correct, for example:
imresize(img, (20,20), CenterPoint(1, 1))
works the same asimresize(img, (20,20))
imresize(img, (20, 20), CenterPoint(5, 5); method=Constant())[5, 5] == img[5, 5]
(If I'm right about the implementation, I'm not sure if it's[5, 5]
here).imresize(imag, (20, 20), CenterPoint(-10, -10))
errors.Also,
OffsetArray
is used widely in the ecosystem, so it would be great to also testOffsetArray(img, -1, -1)
works normally for the above test cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About testing if the
CenterPoint
doesn't change, without overriding the value it can be actully quite different, so either we should override it or it won't be ensured. Except this point I'm working on it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I also noticed this.
BSpline(Constant())
is the nearest interpolation, I believe by using this method, it won't doesn't change the value?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right.