Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ImageBase.restrict #54

Merged
merged 2 commits into from
Jun 2, 2021
Merged

use ImageBase.restrict #54

merged 2 commits into from
Jun 2, 2021

Conversation

johnnychen94
Copy link
Member

A breaking change is that vector inputs now also use restrict; this is unavoidable if we want to reduce the dependencies.

julia> @time using ImageInTerminal
# master:  2.054145 seconds (4.89 M allocations: 353.901 MiB, 4.90% gc time, 0.17% compilation time)
# PR: 1.064598 seconds (2.01 M allocations: 144.469 MiB, 0.32% compilation time)

ImageCore = "0.8.1, 0.9"
ImageTransformations = "0.5, 0.6, 0.7, 0.8"
ImageBase = "0.1"
ImageCore = "0.9"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restrict requires ColorVectorSpace to work. I bump the lower bound of ImageCore to 0.9 because it loads ColorVectorSpace JuliaImages/ImageCore.jl#157

@johnnychen94 johnnychen94 merged commit 3e78503 into master Jun 2, 2021
@johnnychen94 johnnychen94 deleted the jc/imagebase branch June 2, 2021 16:06
@johnnychen94
Copy link
Member Author

Guess @oxinabox might be interested in knowing this since it makes ReferenceTests a lot lighter.

julia> @time using ReferenceTests
# before: 2.225183 seconds (5.65 M allocations: 388.105 MiB)
# after: 1.298767 seconds (2.54 M allocations: 174.356 MiB, 7.41% gc time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants