-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unfortunate OffsetArrays specializations #154
base: master
Are you sure you want to change the base?
Conversation
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 91.65% 91.32% -0.33%
==========================================
Files 9 9
Lines 1222 1234 +12
==========================================
+ Hits 1120 1127 +7
- Misses 102 107 +5
Continue to review full report at Codecov.
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Bummer. Looks like they are still useful. I will have to dig deeper to figure out why. |
Bizarre. I couldn't replicate the performance difference on my laptop for a couple of test cases. Let's see if the rebase somehow magically fixed something. (Seems unlikely, but still...) |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ImageFiltering.jl/ImageFiltering.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
This addresses "Update usage of OffsetArrays" in #142. It wasn't as ugly as I feared, but a nice cleanup nonetheless.
Do not merge this until we get benchmarks that let us assess the consequences of this change. (#152)