[WIP] update benchmark script #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
Jul 18, 2019
There was a problem hiding this comment.
Sorry for my delay in reviewing: I had a simultaneous grant deadline, a deadline for finishing my home reconstruction, and then had to move. I wish others had stepped in to review this!
This looks like a very nice improvement, only small suggestions and then let's merge!
|
|
||
| include("mapwindow.jl") | ||
| const SUITE = BenchmarkGroup(["ImageFIltering"]) |
There was a problem hiding this comment.
Suggested change
| const SUITE = BenchmarkGroup(["ImageFIltering"]) | |
| const SUITE = BenchmarkGroup(["ImageFiltering"]) |
| img_list_gray = [imresize(img_gray_256, ratio=ratio) for ratio in (0.5, 1.0, 2.0, 4.0)] | ||
| img_list_rgb = [imresize(img_rgb_256, ratio=ratio) for ratio in (0.5, 1.0, 2.0, 4.0)] | ||
|
|
||
| default_kernel = centered(ones((31, 31))./prod((31, 31))) |
There was a problem hiding this comment.
What led you to choose the sizes here? (Both for the kernel and the images in the lists.) If running time is a concern we could do everything with smaller images and/or kernels.
|
I completely forget about it. Close in favor of #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current benchmark script is broken, so I redesign it. Hopefully, we can catch a bunch of performance bottleneck with it, and decide where the future efforts should be put on.
A comprehensive benchmark on
ImageFilteringrequires more utils and benchmark items, but I'd like to get some early feedback on this.I plan to make the benchmark script a little bit redundancy so that we can get more performance information about
ImageFiltering. However, this requires quite a long-running time on the local machine (e.g., ~4mins in i7-6700K CPU @ 4.00GHz in the first commit)TODO:
imfiltermapwindow