Thickness and In Bounds check - keyword args #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors when shapes which are partially in the images are attempted to be drawn.
…g paths that went 'off image'
|
To fix CI error on 1.0: # src/compat.jl
if v"1.0" <= VERSION < v"1.1"
isnothing(x) = x===nothing
end |
Codyk12
changed the title
johnnychen94
reviewed
Oct 1, 2019
There was a problem hiding this comment.
Since #29 is a subset of this PR, I think it doesn't need to be merged?
|
|
||
| Overlays an image on an larger image. (x, y) is the center for placing the image | ||
| """ | ||
| struct ImageMap <: Drawable |
There was a problem hiding this comment.
What's the usage of this? I can't find anywhere this struct is used in your PR.
Draft
|
Are there any plans for merging this soon? My use case relies on thickness of lines and otherwise I'll have to fallback to using PIL with PyCall. |
|
We need to merge #29 first and rebase this PR on the top of that I'll see if that one is good to merge. |
|
Unfortunately, this library doesn't have the biggest community supporting it, so we decided to try to use another drawing library to use in the library we're making, hopefully, these features get put merged in soon though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to draw lines with a thickness