Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default metric to DE_2000 #92

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Revert default metric to DE_2000 #92

merged 3 commits into from
Aug 22, 2022

Conversation

adrhill
Copy link
Collaborator

@adrhill adrhill commented Aug 22, 2022

Reverts #87. This is slower, but the output is of much higher quality:

white = RGB{Float32}(1, 1, 1)
yellow = RGB{Float32}(1, 1, 0)
green = RGB{Float32}(0, 0.5, 0)
orange = RGB{Float32}(1, 0.5, 0)
red = RGB{Float32}(1, 0, 0)
blue = RGB{Float32}(0, 0, 1)

rubiks_colors = [white, yellow, green, orange, red, blue]
  • dither(img, rubiks_colors; metric=DE_AB())
    image
  • dither(img, rubiks_colors; metric=DE_2000())
    image

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #92 (c72ec83) into master (09d158d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          12       12           
  Lines         293      293           
=======================================
  Hits          287      287           
  Misses          6        6           
Impacted Files Coverage Δ
src/api/color.jl 90.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adrhill adrhill merged commit a0c73c5 into master Aug 22, 2022
@adrhill adrhill deleted the ah/DE_2000 branch August 22, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant