Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cylindrical <> Spherical conversion #233

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

eliascarv
Copy link
Member

No description provided.

@eliascarv eliascarv requested a review from juliohm December 30, 2024 00:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (a2e9ca7) to head (fb445ac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   94.68%   94.69%           
=======================================
  Files          33       33           
  Lines        1544     1546    +2     
=======================================
+ Hits         1462     1464    +2     
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome @eliascarv, thank you! 💯

@juliohm juliohm merged commit 9eeef06 into main Dec 30, 2024
6 checks passed
@juliohm juliohm deleted the cylindrical-spherical branch December 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants