Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward view to parent for PseudoBlockArray #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 28, 2023

This might help in dispatching to efficient methods for StridedArrays:

julia> B = PseudoBlockArray(collect(reshape(1:36,6,6)), [1,2,3], [1,2,3])
3×3-blocked 6×6 PseudoBlockMatrix{Int64}:
 17  1319  25  31
 ───┼──────────┼────────────
 28  1420  26  32
 39  1521  27  33
 ───┼──────────┼────────────
 410  1622  28  34
 511  1723  29  35
 612  1824  30  36

julia> view(B, Block(2,2))
2×2 view(::Matrix{Int64}, 2:3, 2:3) with eltype Int64:
 8  14
 9  15

julia> view(B, 2:3, 2:3) # new in this PR, matches the above
2×2 view(::Matrix{Int64}, 2:3, 2:3) with eltype Int64:
 8  14
 9  15

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (ee08389) to head (0b44040).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   94.53%   94.54%   +0.01%     
==========================================
  Files          16       16              
  Lines        1501     1504       +3     
==========================================
+ Hits         1419     1422       +3     
  Misses         82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant