Add codemod to rename typing aliases of builtins #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a codemod for Python 3.9+ that updates references like
typing.Listto justlist. It includes all the builtins that have an alias in the typing module.We can also do the same thing for some non-builtin types in the collections module (the full list is in https://peps.python.org/pep-0585/#implementation) but I'm not sure if that should be a separate codemod or added to this one.
I also had to update the RenameCommand to avoid adding imports if the new name is a builtin.
Test Plan
hatch run python -m unittest libcst.codemod.commands.tests.test_rename
hatch run python -m unittest libcst.codemod.commands.tests.test_rename_typing_generic_aliases