Optimize redraw: ElemSetGlow() checks for GlowEn

ImpulseAdventure · Sep 1, 2019 · 4c37e54 · 4c37e54
1 parent ddf0f22
commit 4c37e54
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/GUIslice.c b/src/GUIslice.c
@@ -3395,12 +3395,14 @@ void gslc_ElemSetGlow(gslc_tsGui* pGui,gslc_tsElemRef* pElemRef,bool bGlowing)
     GSLC_DEBUG2_PRINT_CONST(ERRSTR_NULL,FUNCSTR);
     return;
   }
-  // FIXME: Should also check for change in bGlowEn
-  bool bGlowingOld = gslc_ElemGetGlow(pGui,pElemRef);
-  gslc_SetElemRefFlag(pGui,pElemRef,GSLC_ELEMREF_GLOWING,(bGlowing)?GSLC_ELEMREF_GLOWING:0);
+  // Only change glow state if enabled
+  if (gslc_ElemGetGlowEn(pGui, pElemRef)) {
+    bool bGlowingOld = gslc_ElemGetGlow(pGui, pElemRef);
+    gslc_SetElemRefFlag(pGui, pElemRef, GSLC_ELEMREF_GLOWING, (bGlowing) ? GSLC_ELEMREF_GLOWING : 0);
 
-  if (bGlowing != bGlowingOld) {
-    gslc_ElemSetRedraw(pGui,pElemRef,GSLC_REDRAW_INC);
+    if (bGlowing != bGlowingOld) {
+      gslc_ElemSetRedraw(pGui, pElemRef, GSLC_REDRAW_INC);
+    }
   }
 }
 

diff --git a/src/GUIslice_version.h b/src/GUIslice_version.h
@@ -36,7 +36,7 @@
 // Define current release (X.Y.Z) & build number
 // =======================================================================
 
-#define GUISLICE_VER "0.13.0"
+#define GUISLICE_VER "0.13.0.3"
 
 #endif // _GUISLICE_VERSION_H_