Prevent CORS preflight of GET requests #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP GET requests ideally shouldn't require CORS preflighting, which has the effect of doubling the effective latency of every request (as an OPTIONS request will be made prior to every request). Normally, GET requests don't require preflighting, but adding `Content-Type: application/json` triggers preflighting. See https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests for a list of conditions which trigger preflighting. GET requests have no body, so a `Content-Type` header is pointless anyway.
Deploying isic-display-ui with
|
| Latest commit: |
5a87dff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ebf722ef.isic-display-ui.pages.dev |
| Branch Preview URL: | https://cors-get.isic-display-ui.pages.dev |
|
@volishevko Could you review this change? I'm hoping it will improve the performance of the Gallery. If you approve, please ensure that it's also upstreamed into any other internal code repos you have (so it doesn't get overwritten by future PRs). |
|
To clarify, this change will only affect unauthenticated requests (which are still the majority of our users). For authenticated users, the However, we may soon add |
volishevko
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP GET requests ideally shouldn't require CORS preflighting, which has the effect of doubling the effective latency of every request (as an OPTIONS request will be made prior to every request). Normally, GET requests don't require preflighting, but adding
Content-Type: application/jsontriggers preflighting. See https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests for a list of conditions which trigger preflighting.GET requests have no body, so a
Content-Typeheader is pointless anyway.