Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of incorrect reading of current audio time from ffplay … #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coofly
Copy link

@coofly coofly commented Mar 10, 2024

When running the code on Windows system with Conda environment, an error occurs while reading the audio time output by ffplay. Specifically, the failure happens when attempting to convert time[:7] to float type. I have fixed this issue and hope it can be merged.

@wzwz718
Copy link

wzwz718 commented Mar 24, 2024

Got this then:

Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Program Files\Python310\lib\tkinter_init_.py", line 1921, in call
return self.func(*args)
File "C:\Program Files\Python310\lib\tkinter_init_.py", line 839, in callit
func(args)
File "F:\python\Rope\Rope-main\rope\Coordinator.py", line 49, in coordinator
vm.play_video(action[0][1])
File "F:\python\Rope\Rope-main\rope\VideoManager.py", line 291, in play_video
self.current_frame = int(self.fps
sought_time)
ValueError: cannot convert float NaN to integer

@yhqqxq
Copy link

yhqqxq commented May 28, 2024

Okay, it works

@fsjoy52
Copy link

fsjoy52 commented Jun 7, 2024

Exception in Tkinter callback
Traceback (most recent call last):
File "D:\AI\anaconda3\envs\Rope\lib\tkinter_init_.py", line 1921, in call
return self.func(*args)
File "D:\AI\anaconda3\envs\Rope\lib\tkinter_init_.py", line 839, in callit
func(*args)
File "D:\AI\Rope\rope\Coordinator.py", line 49, in coordinator
vm.play_video(action[0][1])
File "D:\AI\Rope\rope\VideoManager.py", line 292, in play_video
sought_time = float(temp[:7])
ValueError: could not convert string to float: b'M-A: '

The problem arises again.windows11 pro 23H2 ver.22631.3672 Pearl-00
This program can complete the face swap and the result is normal. However, if you want to turn on the audio preview, it will report this error.

@pmajor74
Copy link

pmajor74 commented Jul 16, 2024

Ok. I originally thought this a code issue (and it is... the newest FFMPEG is not compatible with Rope...).
The fix for this was to revert my FFMPEG from the latest one to this specific version:
https://github.com/BtbN/FFmpeg-Builds/releases/tag/autobuild-2023-01-31-12-37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants