feat: secure attachment download upload URL's per context #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marrouchi
requested changes
Dec 17, 2024
yassinedorbozgithub
force-pushed
the
422-spike-reseach-possible-design-about-how-to-deal-with-access-to-attachments
branch
from
6b400c9 to
5c1e506
Compare
yassinedorbozgithub
force-pushed
the
422-spike-reseach-possible-design-about-how-to-deal-with-access-to-attachments
branch
from
5c1e506 to
4086c0e
Compare
yassinedorbozgithub
changed the title
marrouchi
requested changes
Dec 19, 2024
Comment on lines
+55
to
+87
| const paths = _parsedUrl.pathname.split('/'); | ||
| const modelFromPathname = paths?.[1].toLowerCase() as TModel; | ||
| const isAttachmentUrl = | ||
| modelFromPathname === 'attachment' && | ||
| ['upload', 'download'].includes(paths?.[2]); | ||
|
|
||
| if (!user && !isAttachmentUrl) { | ||
| throw new UnauthorizedException(); | ||
| } | ||
| if (!session?.cookie || session.cookie.expires < new Date()) { | ||
| throw new UnauthorizedException('Session expired'); | ||
| } | ||
|
|
||
| if (isAttachmentUrl) { | ||
| // attachment | ||
| const attachmentUploadContext = | ||
| query?.context?.toString() as TContextType; | ||
| if ( | ||
| method === 'POST' && | ||
| paths?.[2] === 'upload' && | ||
| attachmentUploadContext | ||
| ) | ||
| return await this.hasRequiredUploadPermission( | ||
| user, | ||
| attachmentUploadContext, | ||
| ); | ||
| else if (method === 'GET' && paths?.[2] === 'download') | ||
| return await this.hasRequiredDownloadPermission(user, paths?.[3]); | ||
| else { | ||
| return false; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's move to the parent class in a protected method called "super.canActivate(...)" or a seperate service or class.
So that here you just call it.
marrouchi
requested changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main motivation of this PR is to make attachment accessible for the owner or the user having the admin role.
Fixes #422
Checklist: